Skip to content

Dealbot #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2021
Merged

Dealbot #84

merged 4 commits into from
Jun 9, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 19, 2021

Initial proposal for storage and retrieval bots project.

@willscott
Copy link
Contributor

cc @travisperson

@ghost ghost force-pushed the bots-proposal branch from b50dc07 to c2732f0 Compare March 19, 2021 19:26
@ghost ghost changed the title Initial proposal Dealbot Mar 22, 2021
Copy link
Contributor

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this got approved without as much review as many of our projects have. Left a comment to try to be more realistic about expected time since this seems clearly to need to be more solid than just some scripts, and to get stewards to weigh in on what's needed for sustainability.



## Project definition
#### Brief plan of attack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Noting that this project doesn't list

  • Unit tests
  • Monitoring of ongoing functionality of the bots
  • Documentation for usage by external entities

With these, we should expect this project to be at least a 'medium' or to take at least 4 weeks of time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 on tests and docs.

For ongoing monitoring, the dashboards project might inadvertently solve for that. If the bots start failing, it will probably be immediately apparent to viewers of the dashboards (e.g., all metrics suddenly go to zero).

- **Phase 2: Storage Bot.** Same idea but for storage deals.
- **Phase 3: Orchestrator.** Invokes the r-bot and s-bot programs with inputs one-by-one from a long queue of CIDs to test retrieve, or files to test store, etc.

#### What does done look like?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do expect to be running this code for some time, and that is comes with both an infra and code burden.

Are there other criteria or thoughts that the stewards have for thinking about what they'd like to see before the project team moves on? cc @BigLep

@mikeal mikeal added confidence:high Confidence rating is 6 or above. impact:high Impact rating is 6 or above. labels Mar 25, 2021
@willscott willscott self-assigned this Mar 25, 2021
@mikeal mikeal added the Bedrock Filecoin Golden Path label Mar 30, 2021
@jacobheun jacobheun merged commit d87b720 into main Jun 9, 2021
@jacobheun jacobheun deleted the bots-proposal branch June 9, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bedrock Filecoin Golden Path confidence:high Confidence rating is 6 or above. impact:high Impact rating is 6 or above.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants